lkml.org 
[lkml]   [2018]   [Sep]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.18 113/145] Revert "UBIFS: Fix potential integer overflow in allocation"
    Date
    4.18-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Richard Weinberger <richard@nod.at>

    commit 08acbdd6fd736b90f8d725da5a0de4de2dd6de62 upstream.

    This reverts commit 353748a359f1821ee934afc579cf04572406b420.
    It bypassed the linux-mtd review process and fixes the issue not as it
    should.

    Cc: Kees Cook <keescook@chromium.org>
    Cc: Silvio Cesare <silvio.cesare@gmail.com>
    Cc: stable@vger.kernel.org
    Signed-off-by: Richard Weinberger <richard@nod.at>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    fs/ubifs/journal.c | 5 ++---
    1 file changed, 2 insertions(+), 3 deletions(-)

    --- a/fs/ubifs/journal.c
    +++ b/fs/ubifs/journal.c
    @@ -1282,11 +1282,10 @@ static int truncate_data_node(const stru
    int *new_len)
    {
    void *buf;
    - int err, compr_type;
    - u32 dlen, out_len, old_dlen;
    + int err, dlen, compr_type, out_len, old_dlen;

    out_len = le32_to_cpu(dn->size);
    - buf = kmalloc_array(out_len, WORST_COMPR_FACTOR, GFP_NOFS);
    + buf = kmalloc(out_len * WORST_COMPR_FACTOR, GFP_NOFS);
    if (!buf)
    return -ENOMEM;


    \
     
     \ /
      Last update: 2018-09-07 23:21    [W:4.052 / U:0.308 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site