Messages in this thread | | | Subject | Re: [PATCH 2/2] mm: Create non-atomic version of SetPageReserved for init use | From | Dave Hansen <> | Date | Tue, 4 Sep 2018 12:27:48 -0700 |
| |
On 09/04/2018 11:33 AM, Alexander Duyck wrote: > +++ b/mm/page_alloc.c > @@ -1231,7 +1231,7 @@ void __meminit reserve_bootmem_region(phys_addr_t start, phys_addr_t end) > /* Avoid false-positive PageTail() */ > INIT_LIST_HEAD(&page->lru); > > - SetPageReserved(page); > + __SetPageReserved(page); > } > } > } > @@ -5518,7 +5518,7 @@ void __meminit memmap_init_zone(unsigned long size, int nid, unsigned long zone, > page = pfn_to_page(pfn); > __init_single_page(page, pfn, zone, nid); > if (context == MEMMAP_HOTPLUG) > - SetPageReserved(page); > + __SetPageReserved(page);
Comments needed, please. SetPageReserved() is opaque enough by itself, but having to discern between it and an __ variant is even less fun.
| |