lkml.org 
[lkml]   [2018]   [Sep]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v3 27/30] ARM: dts: sun8i: h3: use calibration for ths

    Hi Philipp,

    On Thu, 30 Aug 2018 17:45:15 +0200
    Philipp Rossak <embed3d@gmail.com> wrote:

    > The H3 SID is supported by the kernel so we can add a NVMEM Data cell,
    > that contains the calibration data.
    >
    > On the H3 the eFuses are located at the offset 0x200. The thermal data
    > itself has an offset of 0x34 from the eFuse base. So we end on an offset
    > of 0x234.
    >
    > Signed-off-by: Philipp Rossak <embed3d@gmail.com>
    > ---
    > arch/arm/boot/dts/sun8i-h3.dtsi | 9 +++++++++
    > 1 file changed, 9 insertions(+)
    >
    > diff --git a/arch/arm/boot/dts/sun8i-h3.dtsi b/arch/arm/boot/dts/sun8i-h3.dtsi
    > index 1866aec69ec1..0fc447f0c02a 100644
    > --- a/arch/arm/boot/dts/sun8i-h3.dtsi
    > +++ b/arch/arm/boot/dts/sun8i-h3.dtsi
    > @@ -106,8 +106,15 @@
    >
    > soc {
    > sid: eeprom@1c14000 {
    > + #address-cells = <1>;
    > + #size-cells = <1>;
    > compatible = "allwinner,sun8i-h3-sid";
    > reg = <0x01c14000 0x400>;
    > +
    > + /* Data cells */
    > + thermal_calibration: calib@234 {
    > + reg = <0x234 0x8>;
    > + };

    You are declaring 8 bytes of calibration data but to my knowledge it's
    only 2 bytes per sensor, so 2 bytes for H3.
    Am I missing something ?

    Thanks,
    > };
    > };
    >
    > @@ -227,4 +234,6 @@
    > &ths {
    > compatible = "allwinner,sun8i-h3-ths";
    > #thermal-sensor-cells = <0>;
    > + nvmem-cells = <&thermal_calibration>;
    > + nvmem-cell-names = "calibration";
    > };
    > --
    > 2.11.0
    >
    >
    > _______________________________________________
    > linux-arm-kernel mailing list
    > linux-arm-kernel@lists.infradead.org
    > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel


    --
    Emmanuel Vadot <manu@bidouilliste.com> <manu@freebsd.org>

    \
     
     \ /
      Last update: 2018-09-04 18:46    [W:4.654 / U:0.104 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site