Messages in this thread | | | Subject | Re: [PATCHv2 1/4] tty: Drop tty->count on tty_reopen() failure | From | Jiri Slaby <> | Date | Tue, 4 Sep 2018 10:58:54 +0200 |
| |
On 09/03/2018, 06:52 PM, Dmitry Safonov wrote: > In case of tty_ldisc_reinit() failure, tty->count should be decremented > back, otherwise we will never release_tty(). > Tetsuo reported that it fixes noisy warnings on tty release like: > pts pts4033: tty_release: tty->count(10529) != (#fd's(7) + #kopen's(0)) > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: Jiri Slaby <jslaby@suse.com> > Cc: stable@vger.kernel.org # v4.6+ > Fixes: commit 892d1fa7eaae ("tty: Destroy ldisc instance on hangup") > Tested-by: Jiri Slaby <jslaby@suse.com>
Reviewed-by: Jiri Slaby <jslaby@suse.cz>
> Tested-by: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp> > Signed-off-by: Dmitry Safonov <dima@arista.com>
thanks, -- js suse labs
| |