Messages in this thread Patch in this message | | | From | "Eric W. Biederman" <> | Date | Mon, 3 Sep 2018 22:44:25 +0200 | Subject | [PATCH 05/10] signal: send_sig_all no longer needs SEND_SIG_FORCED |
| |
Now that send_signal always delivers SEND_SIG_PRIV signals to a pid namespace init it is no longer necessary to use SEND_SIG_FORCED when calling do_send_sig_info to ensure that pid namespace inits are signaled and possibly killed. Using SEND_SIG_PRIV is sufficient.
So use SEND_SIG_PRIV so that userspace when it receives a SIGTERM can tell that the kernel sent the signal and not some random userspace application.
Fixes: b82c32872db2 ("sysrq: use SEND_SIG_FORCED instead of force_sig()") Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com> --- drivers/tty/sysrq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/sysrq.c b/drivers/tty/sysrq.c index 06ed20dd01ba..ad1ee5d01b53 100644 --- a/drivers/tty/sysrq.c +++ b/drivers/tty/sysrq.c @@ -348,7 +348,7 @@ static void send_sig_all(int sig) if (is_global_init(p)) continue; - do_send_sig_info(sig, SEND_SIG_FORCED, p, PIDTYPE_MAX); + do_send_sig_info(sig, SEND_SIG_PRIV, p, PIDTYPE_MAX); } read_unlock(&tasklist_lock); } -- 2.17.1
| |