lkml.org 
[lkml]   [2018]   [Sep]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 005/165] esp6: fix memleak on error path in esp6_input
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Zhen Lei <thunder.leizhen@huawei.com>

    [ Upstream commit 7284fdf39a912322ce97de2d30def3c6068a418c ]

    This ought to be an omission in e6194923237 ("esp: Fix memleaks on error
    paths."). The memleak on error path in esp6_input is similar to esp_input
    of esp4.

    Fixes: e6194923237 ("esp: Fix memleaks on error paths.")
    Fixes: 3f29770723f ("ipsec: check return value of skb_to_sgvec always")
    Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
    Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    net/ipv6/esp6.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    --- a/net/ipv6/esp6.c
    +++ b/net/ipv6/esp6.c
    @@ -651,8 +651,10 @@ skip_cow:

    sg_init_table(sg, nfrags);
    ret = skb_to_sgvec(skb, sg, 0, skb->len);
    - if (unlikely(ret < 0))
    + if (unlikely(ret < 0)) {
    + kfree(tmp);
    goto out;
    + }

    skb->ip_summed = CHECKSUM_NONE;


    \
     
     \ /
      Last update: 2018-09-03 19:48    [W:4.095 / U:0.136 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site