Messages in this thread Patch in this message | | | From | Christian Brauner <> | Subject | [PATCH net-next v1 5/5] rtnetlink: move type calculation out of loop | Date | Mon, 3 Sep 2018 06:37:17 +0200 |
| |
I don't see how the type - which is one of RTM_{GETADDR,GETROUTE,GETNETCONF} - can change. So do the message type calculation once before entering the for loop.
Signed-off-by: Christian Brauner <christian@brauner.io> --- v0->v1: - unchanged --- net/core/rtnetlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c index 30645d9a9801..b36dab7507a0 100644 --- a/net/core/rtnetlink.c +++ b/net/core/rtnetlink.c @@ -3265,13 +3265,13 @@ static int rtnl_dump_all(struct sk_buff *skb, struct netlink_callback *cb) { int idx; int s_idx = cb->family; + int type = cb->nlh->nlmsg_type - RTM_BASE; if (s_idx == 0) s_idx = 1; for (idx = 1; idx <= RTNL_FAMILY_MAX; idx++) { struct rtnl_link **tab; - int type = cb->nlh->nlmsg_type-RTM_BASE; struct rtnl_link *link; rtnl_dumpit_func dumpit; -- 2.17.1
| |