Messages in this thread | | | Date | Fri, 28 Sep 2018 14:48:15 +0100 | From | Mark Rutland <> | Subject | Re: [PATCH 2/3] ARM: psci: Fix secondary core boot with THUMB2_KERNEL |
| |
On Thu, Sep 27, 2018 at 12:27:10PM -0700, Florian Fainelli wrote: > When THUMB2_KERNEL is enabled, we would be setting the secondary core's > entry point to secondary_startup() which is already Thumb2 code, utilize > secondary_startup_arm() which takes care of doing the mode switching for > us.
As with the first patch, a call to CPU_ON with bit[0] set in the entry point *should* place the CPU into thumb state, so I'd like to know which FW you've seen this bug with.
Thanks, Mark.
> > Fixes: 05774088391c ("arm: introduce psci_smp_ops") > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> > --- > arch/arm/kernel/psci_smp.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/kernel/psci_smp.c b/arch/arm/kernel/psci_smp.c > index cb3fcaeb2233..547a11b065d2 100644 > --- a/arch/arm/kernel/psci_smp.c > +++ b/arch/arm/kernel/psci_smp.c > @@ -47,13 +47,13 @@ > * > */ > > -extern void secondary_startup(void); > +extern void secondary_startup_arm(void); > > static int psci_boot_secondary(unsigned int cpu, struct task_struct *idle) > { > if (psci_ops.cpu_on) > return psci_ops.cpu_on(cpu_logical_map(cpu), > - virt_to_idmap(&secondary_startup)); > + virt_to_idmap(&secondary_startup_arm)); > return -ENODEV; > } > > -- > 2.17.1 >
| |