Messages in this thread | | | Date | Thu, 27 Sep 2018 23:47:52 +0200 | From | Pavel Machek <> | Subject | Re: [RFC PATCH 7/9] leds: lm3633: Introduce the lm3633 driver |
| |
Hi!
> > Duplicate. > > > > Can we get some more sharing? One way would be to have struct with > > all the constants (instead of #defines) use that...? > > I will look at the adding common constants to but they should be common across > more then just 2 devices. As you can see the LM3632 code is quite different > when you add in the flash/torch support.
LM3632 is indeed different, I see.
On the other hand, I'd really like to see the code shared, even if it is just for 2 devices. (I believe that family is big enough that we'll likely see more sharing in future).
Thanks,
Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html [unhandled content-type:application/pgp-signature] | |