Messages in this thread | | | Date | Thu, 27 Sep 2018 16:11:14 +0300 | From | Jarkko Sakkinen <> | Subject | Re: [PATCH v14 12/19] x86/sgx: Add data structures for tracking the EPC pages |
| |
On Tue, Sep 25, 2018 at 01:00:42PM -0700, Randy Dunlap wrote: > On 9/25/18 6:06 AM, Jarkko Sakkinen wrote: > > Add data structures to track Enclave Page Cache (EPC) pages. EPC is > > divided into multiple banks (1-N) of which addresses and sizes can be > > enumerated with CPUID by the OS. > > > > On NUMA systems a node can have at most bank. A bank can be at most part of > > two nodes. SGX supports both nodes with a single memory controller and also > > sub-cluster nodes with severals memory controllers on a single die. > > > > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> > > Co-developed-by: Serge Ayoun <serge.ayoun@intel.com> > > Co-developed-by: Sean Christopherson <sean.j.christopherson@intel.com> > > Signed-off-by: Serge Ayoun <serge.ayoun@intel.com> > > Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com> > > --- > > arch/x86/include/asm/sgx.h | 55 +++++++++++++++ > > arch/x86/kernel/cpu/intel_sgx.c | 115 ++++++++++++++++++++++++++++++++ > > 2 files changed, 170 insertions(+) > > Hi, > > Several comment blocks begin with "/**" but they are either not intended > to be kernel-doc notation or they are incomplete kernel-doc notation.
I'll enumerate them through.
Thank you for the feedback.
/Jarkko
| |