Messages in this thread | | | From | Naga Sureshkumar Relli <> | Subject | RE: [LINUX PATCH v11 1/3] dt-bindings: mtd: arasan: Add device tree binding documentation | Date | Thu, 27 Sep 2018 10:57:35 +0000 |
| |
Hi Rob,
Thanks for the review.
> -----Original Message----- > From: Rob Herring [mailto:robh@kernel.org] > Sent: Wednesday, September 26, 2018 6:48 PM > To: Naga Sureshkumar Relli <nagasure@xilinx.com> > Cc: boris.brezillon@bootlin.com; miquel.raynal@bootlin.com; richard@nod.at; > dwmw2@infradead.org; computersforpeace@gmail.com; marek.vasut@gmail.com; linux- > mtd@lists.infradead.org; Linux Kernel Mailing List <linux-kernel@vger.kernel.org>; Michal > Simek <michals@xilinx.com>; nagasuresh12@gmail.com > Subject: Re: [LINUX PATCH v11 1/3] dt-bindings: mtd: arasan: Add device tree binding > documentation > > DT bindings should be sent to DT list. Since last 4 version of patches I am sending like this. Thanks for letting us know. Currently I am waiting for arasan_nand driver review. Once it is done, I will address all the comments and send new version, along with the driver changes
Thanks, Naga Sureshkumar Relli
> > On Tue, Sep 25, 2018 at 7:21 AM Naga Sureshkumar Relli > <naga.sureshkumar.relli@xilinx.com> wrote: > > > > This patch adds the dts binding document for arasan nand flash > > controller > > > > Signed-off-by: Naga Sureshkumar Relli > > <naga.sureshkumar.relli@xilinx.com> > > --- > > Changes in v11: > > - Updated compatible description as suggested by Boris > > - Removed arasan-has-dma property > > Changes in v10: > > - None > > Changes in v9: > > - None > > Changes in v8: > > - Updated compatible and clock-names as per Boris comments Changes in > > v7: > > - Corrected the acronyms those should be in caps Changes in v6: > > - Removed num-cs property > > - Separated nandchip from nand controller Changes in v5: > > - None > > Changes in v4: > > - Added num-cs property > > - Added clock support > > Changes in v3: > > - None > > Changes in v2: > > - None > > --- > > .../devicetree/bindings/mtd/arasan_nand.txt | 33 ++++++++++++++++++++++ > > 1 file changed, 33 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/mtd/arasan_nand.txt > > > > diff --git a/Documentation/devicetree/bindings/mtd/arasan_nand.txt > > b/Documentation/devicetree/bindings/mtd/arasan_nand.txt > > new file mode 100644 > > index 0000000..546ed98 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/mtd/arasan_nand.txt > > @@ -0,0 +1,33 @@ > > +Arasan NAND Flash Controller with ONFI 3.1 support > > + > > +Required properties: > > +- compatible: Should be "xlnx,zynqmp-nand", "arasan,nfc-v3p10" > > +- reg: Memory map for module access > > +- interrupt-parent: Interrupt controller the interrupt is routed through > > Drop this. It is implied. > > > +- interrupts: Should contain the interrupt for the device > > +- clock-name: List of input clocks - "sys", "flash" > > + (See clock bindings for details) > > +- clocks: Clock phandles (see clock bindings for details) > > + > > +Required properties for child node: > > +- nand-ecc-mode: see nand.txt > > + > > +For NAND partition information please refer the below file > > +Documentation/devicetree/bindings/mtd/partition.txt > > + > > +Example: > > + nfc: nand@ff100000 { > > + compatible = "xlnx,zynqmp-nand", "arasan,nfc-v3p10" > > Missing ; > > > + reg = <0x0 0xff100000 0x1000>; > > + clock-name = "sys", "flash" > > Missing ; > > > + clocks = <&misc_clk &misc_clk>; > > + interrupt-parent = <&gic>; > > + interrupts = <0 14 4>; > > + #address-cells = <1>; > > + #size-cells = <0> > > Missing ; > > > + > > + nand@0 { > > + reg = <0> > > Missing ; > > > + nand-ecc-mode = "hw"; > > + }; > > + }; > > -- > > 2.7.4 > >
| |