lkml.org 
[lkml]   [2018]   [Sep]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] usb: typec: fusb302: Correct spelling mistake for toggling state
On Wed, Sep 26, 2018 at 04:23:51PM +0100, Adam Thomson wrote:
> There's a typo in the enum name of the 'OFF' state for toggling
> (TOGGLINE instead of TOGGLING). This commit resolves that trivial
> spelling inconsistency.
>
> Signed-off-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>

Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>

> ---
> drivers/usb/typec/tcpm/fusb302.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/usb/typec/tcpm/fusb302.c b/drivers/usb/typec/tcpm/fusb302.c
> index 6e9370a..fd851d8 100644
> --- a/drivers/usb/typec/tcpm/fusb302.c
> +++ b/drivers/usb/typec/tcpm/fusb302.c
> @@ -42,7 +42,7 @@
> #define T_BC_LVL_DEBOUNCE_DELAY_MS 30
>
> enum toggling_mode {
> - TOGGLINE_MODE_OFF,
> + TOGGLING_MODE_OFF,
> TOGGLING_MODE_DRP,
> TOGGLING_MODE_SNK,
> TOGGLING_MODE_SRC,
> @@ -594,7 +594,7 @@ static int fusb302_set_toggling(struct fusb302_chip *chip,
> chip->intr_comp_chng = false;
> /* configure toggling mode: none/snk/src/drp */
> switch (mode) {
> - case TOGGLINE_MODE_OFF:
> + case TOGGLING_MODE_OFF:
> ret = fusb302_i2c_mask_write(chip, FUSB_REG_CONTROL2,
> FUSB_REG_CONTROL2_MODE_MASK,
> FUSB_REG_CONTROL2_MODE_NONE);
> @@ -626,7 +626,7 @@ static int fusb302_set_toggling(struct fusb302_chip *chip,
> break;
> }
>
> - if (mode == TOGGLINE_MODE_OFF) {
> + if (mode == TOGGLING_MODE_OFF) {
> /* mask TOGDONE interrupt */
> ret = fusb302_i2c_set_bits(chip, FUSB_REG_MASKA,
> FUSB_REG_MASKA_TOGDONE);
> @@ -702,7 +702,7 @@ static int tcpm_set_cc(struct tcpc_dev *dev, enum typec_cc_status cc)
> ret = -EINVAL;
> goto done;
> }
> - ret = fusb302_set_toggling(chip, TOGGLINE_MODE_OFF);
> + ret = fusb302_set_toggling(chip, TOGGLING_MODE_OFF);
> if (ret < 0) {
> fusb302_log(chip, "cannot stop toggling, ret=%d", ret);
> goto done;
> @@ -1292,7 +1292,7 @@ static int fusb302_handle_togdone_snk(struct fusb302_chip *chip,
> tcpm_cc_change(chip->tcpm_port);
> }
> /* turn off toggling */
> - ret = fusb302_set_toggling(chip, TOGGLINE_MODE_OFF);
> + ret = fusb302_set_toggling(chip, TOGGLING_MODE_OFF);
> if (ret < 0) {
> fusb302_log(chip,
> "cannot set toggling mode off, ret=%d", ret);
> @@ -1388,7 +1388,7 @@ static int fusb302_handle_togdone_src(struct fusb302_chip *chip,
> tcpm_cc_change(chip->tcpm_port);
> }
> /* turn off toggling */
> - ret = fusb302_set_toggling(chip, TOGGLINE_MODE_OFF);
> + ret = fusb302_set_toggling(chip, TOGGLING_MODE_OFF);
> if (ret < 0) {
> fusb302_log(chip,
> "cannot set toggling mode off, ret=%d", ret);
> --
> 1.9.1

--
heikki

\
 
 \ /
  Last update: 2018-09-27 12:55    [W:0.122 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site