lkml.org 
[lkml]   [2018]   [Sep]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 22/64] ALSA: firewire-digi00x: fix memory leak of private data
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Takashi Sakamoto <o-takashi@sakamocchi.jp>

    commit a49a83ab05e34edd6c71a4fbd062c9a7ba6d18aa upstream.

    Although private data of sound card instance is usually allocated in the
    tail of the instance, drivers in ALSA firewire stack allocate the private
    data before allocating the instance. In this case, the private data
    should be released explicitly at .private_free callback of the instance.

    This commit fixes memory leak following to the above design.

    Fixes: 86c8dd7f4da3 ('ALSA: firewire-digi00x: delayed registration of sound card')
    Cc: <stable@vger.kernel.org> # v4.7+
    Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    sound/firewire/digi00x/digi00x.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/sound/firewire/digi00x/digi00x.c
    +++ b/sound/firewire/digi00x/digi00x.c
    @@ -49,6 +49,7 @@ static void dg00x_free(struct snd_dg00x
    fw_unit_put(dg00x->unit);

    mutex_destroy(&dg00x->mutex);
    + kfree(dg00x);
    }

    static void dg00x_card_free(struct snd_card *card)

    \
     
     \ /
      Last update: 2018-09-27 11:19    [W:3.082 / U:0.088 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site