lkml.org 
[lkml]   [2018]   [Sep]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 4/5] usb: host: Add XHCI driver for Broadcom STB SoCs
    Date

    Hi,

    Al Cooper <alcooperx@gmail.com> writes:

    > This driver enables USB XHCI on Broadcom ARM STB SoCs.
    > The drivers depend on a matching "brcm,brcmstb-usb-phy"
    > Broadcom STB USB Phy driver.
    >
    > The standard platform driver can't be used because of differences
    > in PHY and Clock handling. The standard PHY handling in hcd.c will
    > do a phy_exit/phy_init on suspend/resume and this will end up
    > shutting down the PHYs to the point that the host controller
    > registers are no longer accessible and will cause suspend to crash.
    > The clocks specified in device tree for these drivers are not
    > available in mainline so instead of returning EPROBE_DEFER when
    > the specified clock is not found and eventually failing probe,
    > the clock pointer is set to NULL which disables all clock handling.
    >
    > Signed-off-by: Al Cooper <alcooperx@gmail.com>
    > ---
    > drivers/usb/host/xhci-brcm.c | 294 +++++++++++++++++++++++++++++++++++++++++++

    this looks a lot like xhci-plat.c, why don't you use that instead?

    -
    balbi

    \
     
     \ /
      Last update: 2018-09-27 07:58    [W:5.208 / U:0.820 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site