Messages in this thread | | | Date | Thu, 27 Sep 2018 11:39:13 -0700 | From | Nicolin Chen <> | Subject | Re: [PATCH 2/2] hwmon: ina3221: Add enable sysfs nodes |
| |
Hello Guenter,
On Thu, Sep 27, 2018 at 09:05:09AM -0700, Guenter Roeck wrote: > > > Point is that I don't _know_ how this is going to be used, so I'd > > > rather keep it flexible. > > > > Well, taking one step back, I am okay to follow your way if you > > are really firm about it. Just please give me a more reply and > > I will merge this change to that v5, dropping the is_visible(). > > Quite obviously we are not converging. Given that, I think it > would be better to shelve the new attributes for now and to wait > for an actual user who actually needs the new attributes.
I would rather remove the hiding code, if we have to sacrifice one of them. We both agreed that in[123]_enable is more useful. And actually we will still keep is_visible() for empty labels. So even if one day we somehow feel safe to hide a disconnected channel one day, it'd only need a couple of lines of changes.
I will squash this change into v6, and will send it after I fix things that Rob pointed out at DT binding.
Thank you Nicolin
| |