lkml.org 
[lkml]   [2018]   [Sep]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] powerpc: Move a dereference below a NULL test
From
Date


Le 26/09/2018 à 13:46, zhong jiang a écrit :
> It is safe to move dereference below a NULL test.
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> ---
> arch/powerpc/kernel/cacheinfo.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/arch/powerpc/kernel/cacheinfo.c b/arch/powerpc/kernel/cacheinfo.c
> index a8f20e5..7f19714 100644
> --- a/arch/powerpc/kernel/cacheinfo.c
> +++ b/arch/powerpc/kernel/cacheinfo.c
> @@ -401,14 +401,13 @@ static struct cache *cache_lookup_or_instantiate(struct device_node *node,
> struct cache *cache;
>
> cache = cache_lookup_by_node(node);
> + if (!cache)
> + cache = cache_do_one_devnode(node, level);

But by doing this, you change the meaning of the following warning. Is
that what you want ? In that case the text of the WARN_ONCE() should be
changed, because the mismatch is not only on lookup now.

Christophe

>
> WARN_ONCE(cache && cache->level != level,
> "cache level mismatch on lookup (got %d, expected %d)\n",
> cache->level, level);
>
> - if (!cache)
> - cache = cache_do_one_devnode(node, level);
> -
> return cache;
> }
>
>

\
 
 \ /
  Last update: 2018-09-26 15:59    [W:0.040 / U:0.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site