Messages in this thread | | | Date | Wed, 26 Sep 2018 16:43:35 +0300 | From | Mike Rapoport <> | Subject | Re: [PATCH 14/30] memblock: add align parameter to memblock_alloc_node() |
| |
On Wed, Sep 26, 2018 at 11:36:48AM +0200, Michal Hocko wrote: > On Wed 26-09-18 11:31:27, Michal Hocko wrote: > > On Fri 14-09-18 15:10:29, Mike Rapoport wrote: > > > With the align parameter memblock_alloc_node() can be used as drop in > > > replacement for alloc_bootmem_pages_node() and __alloc_bootmem_node(), > > > which is done in the following patches. > > > > /me confused. Why do we need this patch at all? Maybe it should be > > folded into the later patch you are refereing here? > > OK, I can see 1536927045-23536-17-git-send-email-rppt@linux.vnet.ibm.com > now. If you are going to repost for whatever reason please merge those > two. Also I would get rid of the implicit "0 implies SMP_CACHE_BYTES" > behavior. It is subtle and you have to dig deep to find that out. Why > not make it explicit?
Agree. I'd just prefer to make it a separate patch rather then resend the whole series.
> -- > Michal Hocko > SUSE Labs >
-- Sincerely yours, Mike.
| |