lkml.org 
[lkml]   [2018]   [Sep]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v3 2/2] powerpc/64: add stack protector support
Date
Christophe LEROY <christophe.leroy@c-s.fr> writes:
> Le 26/09/2018 à 11:28, Segher Boessenkool a écrit :
>> On Wed, Sep 26, 2018 at 09:58:30AM +0200, Christophe LEROY wrote:
>>> Segher, any idea about this problem ?
>>
>>>>> arch/powerpc/platforms/powermac/bootx_init.o: In function `bootx_printf':
>>>>> /var/lib/jenkins-slave/workspace/snowpatch/snowpatch-linux-
>>>>> sparse/linux/arch/powerpc/platforms/powermac/bootx_init.c:88:
>>>>> undefined reference to `__stack_chk_fail_local'
>>
>> Are you building as PIC? Are you linking libssp_nonshared.a? Why not?
>
> Spotted, thanks.
>
> arch/powerpc/platforms/powermac/Makefile contains:
>
> CFLAGS_bootx_init.o += -fPIC
...
>
> Or maybe stack protection on bootx_init doesn't make much sense and we
> could just do the following ?
>
> CFLAGS_bootx_init.o += -fPIC $(call cc-option, -fno-stack-protector)

That would be fine by me.

cheers

\
 
 \ /
  Last update: 2018-09-26 13:52    [W:1.609 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site