Messages in this thread | | | Subject | Re: [PATCH v5 13/23] iommu: introduce device fault report API | From | Jean-Philippe Brucker <> | Date | Wed, 26 Sep 2018 11:14:05 +0100 |
| |
On 25/09/2018 23:17, Jacob Pan wrote: > On Tue, 25 Sep 2018 15:58:41 +0100 > Jean-Philippe Brucker <jean-philippe.brucker@arm.com> wrote: > >> Hi Jacob, >> >> Just two minor things below, that I noticed while using fault handlers >> for SVA. From my perspective the series is fine otherwise >> >> On 11/05/2018 21:54, Jacob Pan wrote: >> > +int iommu_unregister_device_fault_handler(struct device *dev) >> > +{ >> > + struct iommu_param *param = dev->iommu_param; >> > + int ret = 0; >> > + >> > + if (!param) >> > + return -EINVAL; >> > + >> > + mutex_lock(¶m->lock); >> >> Could we check that param->fault_param isn't NULL here, so that the >> driver can call this function unconditionally in a cleanup path? >> > sounds good. > > if (!param || param->fault_param) > return -EINVAL;
That would be too convenient... param needs to be checked before taking the lock, and fault_param accessed after
Thanks, Jean
| |