Messages in this thread | | | From | Doug Anderson <> | Date | Tue, 25 Sep 2018 12:54:35 -0700 | Subject | Re: [PATCH V4 3/4] spi: spi-geni-qcom: Add SPI driver support for GENI based QUP |
| |
Hi,
On Tue, Sep 25, 2018 at 12:36 PM <dkota@codeaurora.org> wrote: > >> + unsigned int cur_speed_hz; > > > > unsigned long for Hz? The clk framework uses that type. > > cur_speed_hz stores the speed value requested as part of transfer (not > the resultant or rounded off frequency got from clk framework. It is u32 > type, i will change cur_speed_hz to u32 type instead of unsigned long. > Code snippet: > mas->cur_speed_hz = xfer->speed_hz;
Change it to "unsigned long" anyway to match the clock framework. In theory maybe the "xfer" structure will be updated eventually.
-Doug
| |