lkml.org 
[lkml]   [2018]   [Sep]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.18 042/235] IB/ipoib: Fix error return code in ipoib_dev_init()
    Date
    4.18-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Wei Yongjun <weiyongjun1@huawei.com>

    [ Upstream commit 99a7e2bf704d64c966dfacede1ba2d9b47cb676e ]

    Fix to return a negative error code from the ipoib_neigh_hash_init()
    error handling case instead of 0, as done elsewhere in this function.

    Fixes: 515ed4f3aab4 ("IB/IPoIB: Separate control and data related initializations")
    Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
    Reviewed-by: Yuval Shaia <yuval.shaia@oracle.com>
    Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/infiniband/ulp/ipoib/ipoib_main.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    --- a/drivers/infiniband/ulp/ipoib/ipoib_main.c
    +++ b/drivers/infiniband/ulp/ipoib/ipoib_main.c
    @@ -1787,7 +1787,8 @@ int ipoib_dev_init(struct net_device *de
    goto out_free_pd;
    }

    - if (ipoib_neigh_hash_init(priv) < 0) {
    + ret = ipoib_neigh_hash_init(priv);
    + if (ret) {
    pr_warn("%s failed to init neigh hash\n", dev->name);
    goto out_dev_uninit;
    }

    \
     
     \ /
      Last update: 2018-09-24 14:37    [W:4.091 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site