lkml.org 
[lkml]   [2018]   [Sep]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 065/173] platform/x86: toshiba_acpi: Fix defined but not used build warnings
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Randy Dunlap <rdunlap@infradead.org>

    [ Upstream commit c2e2a618eb7104e18fdcf739d4d911563812a81c ]

    Fix a build warning in toshiba_acpi.c when CONFIG_PROC_FS is not enabled
    by marking the unused function as __maybe_unused.

    ../drivers/platform/x86/toshiba_acpi.c:1685:12: warning: 'version_proc_show' defined but not used [-Wunused-function]

    Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
    Cc: Azael Avalos <coproscefalo@gmail.com>
    Cc: platform-driver-x86@vger.kernel.org
    Cc: Andy Shevchenko <andy@infradead.org>
    Signed-off-by: Darren Hart (VMware) <dvhart@infradead.org>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/platform/x86/toshiba_acpi.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    --- a/drivers/platform/x86/toshiba_acpi.c
    +++ b/drivers/platform/x86/toshiba_acpi.c
    @@ -34,6 +34,7 @@
    #define TOSHIBA_ACPI_VERSION "0.24"
    #define PROC_INTERFACE_VERSION 1

    +#include <linux/compiler.h>
    #include <linux/kernel.h>
    #include <linux/module.h>
    #include <linux/moduleparam.h>
    @@ -1682,7 +1683,7 @@ static const struct file_operations keys
    .write = keys_proc_write,
    };

    -static int version_proc_show(struct seq_file *m, void *v)
    +static int __maybe_unused version_proc_show(struct seq_file *m, void *v)
    {
    seq_printf(m, "driver: %s\n", TOSHIBA_ACPI_VERSION);
    seq_printf(m, "proc_interface: %d\n", PROC_INTERFACE_VERSION);

    \
     
     \ /
      Last update: 2018-09-24 14:20    [W:4.089 / U:0.656 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site