lkml.org 
[lkml]   [2018]   [Sep]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.18 013/105] powerpc: Fix size calculation using resource_size()
    Date
    3.18-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Dan Carpenter <dan.carpenter@oracle.com>

    [ Upstream commit c42d3be0c06f0c1c416054022aa535c08a1f9b39 ]

    The problem is the the calculation should be "end - start + 1" but the
    plus one is missing in this calculation.

    Fixes: 8626816e905e ("powerpc: add support for MPIC message register API")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Reviewed-by: Tyrel Datwyler <tyreld@linux.vnet.ibm.com>
    Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    arch/powerpc/sysdev/mpic_msgr.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/arch/powerpc/sysdev/mpic_msgr.c
    +++ b/arch/powerpc/sysdev/mpic_msgr.c
    @@ -196,7 +196,7 @@ static int mpic_msgr_probe(struct platfo

    /* IO map the message register block. */
    of_address_to_resource(np, 0, &rsrc);
    - msgr_block_addr = ioremap(rsrc.start, rsrc.end - rsrc.start);
    + msgr_block_addr = ioremap(rsrc.start, resource_size(&rsrc));
    if (!msgr_block_addr) {
    dev_err(&dev->dev, "Failed to iomap MPIC message registers");
    return -EFAULT;

    \
     
     \ /
      Last update: 2018-09-24 13:37    [W:6.096 / U:0.092 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site