lkml.org 
[lkml]   [2018]   [Sep]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 012/173] hv/netvsc: Fix NULL dereference at single queue mode fallback
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Takashi Iwai <tiwai@suse.de>

    commit b19b46346f483ae055fa027cb2d5c2ca91484b91 upstream.

    The recent commit 916c5e1413be ("hv/netvsc: fix handling of fallback
    to single queue mode") tried to fix the fallback behavior to a single
    queue mode, but it changed the function to return zero incorrectly,
    while the function should return an object pointer. Eventually this
    leads to a NULL dereference at the callers that expect non-NULL
    value.

    Fix it by returning the proper net_device object.

    Fixes: 916c5e1413be ("hv/netvsc: fix handling of fallback to single queue mode")
    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Reviewed-by: Stephen Hemminger <stephen@networkplumber.org>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Cc: Alakesh Haloi <alakeshh@amazon.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/net/hyperv/rndis_filter.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/net/hyperv/rndis_filter.c
    +++ b/drivers/net/hyperv/rndis_filter.c
    @@ -1299,7 +1299,7 @@ out:
    /* setting up multiple channels failed */
    net_device->max_chn = 1;
    net_device->num_chn = 1;
    - return 0;
    + return net_device;

    err_dev_remv:
    rndis_filter_device_remove(dev, net_device);

    \
     
     \ /
      Last update: 2018-09-24 14:58    [W:4.054 / U:0.364 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site