lkml.org 
[lkml]   [2018]   [Sep]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 3.16 51/63] xfs: catch inode allocation state mismatch corruption
    From
    Date
    On Sat, 2018-09-22 at 15:25 +1000, Dave Chinner wrote:
    > On Sat, Sep 22, 2018 at 01:15:42AM +0100, Ben Hutchings wrote:
    > > 3.16.58-rc1 review patch. If anyone has any objections, please let
    > > me know.
    > >
    > > ------------------
    > >
    > > From: Dave Chinner <dchinner@redhat.com>
    > >
    > > commit ee457001ed6c6f31ddad69c24c1da8f377d8472d upstream.
    > >
    > > We recently came across a V4 filesystem causing memory corruption
    > > due to a newly allocated inode being setup twice and being added to
    > > the superblock inode list twice. From code inspection, the only way
    > > this could happen is if a newly allocated inode was not marked as
    > > free on disk (i.e. di_mode wasn't zero).
    >
    > ....
    > > Signed-Off-By: Dave Chinner <dchinner@redhat.com>
    > > Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>
    > > Tested-by: Carlos Maiolino <cmaiolino@redhat.com>
    > > Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
    > > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
    > > [bwh: Backported to 3.16:
    > > - Look up mode in XFS inode, not VFS inode
    > > - Use positive error codes, and EIO instead of EFSCORRUPTED]
    >
    > Why EIO?

    I believe EIO was the usual error code used for filesystem errors
    before EFSCORRUPTED was added. But now I see xfs had its own private
    definition of EFSCORRUPTED. I'll change this back.

    Ben.

    --
    Ben Hutchings
    Any sufficiently advanced bug is indistinguishable from a feature.


    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2018-09-22 22:58    [W:4.001 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site