lkml.org 
[lkml]   [2018]   [Sep]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [patch V3 02/11] x86/mm/cpa: Split, rename and clean up try_preserve_large_page()
From
Date
On 09/17/2018 07:29 AM, Thomas Gleixner wrote:
> Avoid the extra variable and gotos by splitting the function into the
> actual algorithm and a callable function which contains the lock
> protection.
>
> Rename it to should_split_large_page() while at it so the return values make
> actually sense.
>
> Clean up the code flow, comments and general whitespace damage while at it. No
> functional change.
>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

This one is getting a wee bit hard to follow from the diff, but the
cleanup and rename looks nice.

Reviewed-by: Dave Hansen <dave.hansen@intel.com>

\
 
 \ /
  Last update: 2018-09-21 18:23    [W:0.450 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site