Messages in this thread | | | Date | Thu, 20 Sep 2018 00:34:15 -0700 | From | Bjorn Andersson <> | Subject | Re: [PATCH] firmware: Always initialize the fw_priv list object |
| |
On Wed 19 Sep 22:22 PDT 2018, Greg Kroah-Hartman wrote:
> On Wed, Sep 19, 2018 at 06:09:38PM -0700, Bjorn Andersson wrote: > > When freeing the fw_priv the item is taken off the list. This causes an > > oops in the FW_OPT_NOCACHE case as the list object is not initialized. > > > > Make sure to initialize the list object regardless of this flag. > > > > Fixes: 422b3db2a503 ("firmware: Fix security issue with request_firmware_into_buf()") > > Cc: stable@vger.kernel.org > > Cc: Rishabh Bhatnagar <rishabhb@codeaurora.org> > > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> > > --- > > drivers/base/firmware_loader/main.c | 7 +++++-- > > 1 file changed, 5 insertions(+), 2 deletions(-) > > Is this being triggered by some hardware somewhere today? Or is this > just a fix found by code inspection? >
Hi Greg,
Yes, I found this issue while attempting to load the firmware and boot one of the DSPs on one of my Qualcomm dev boards after v4.19-rc4 and it can be reproduced on the upstream Dragonboard 820c.
Regards, Bjorn
| |