Messages in this thread | | | Date | Wed, 19 Sep 2018 23:11:57 -0700 (PDT) | Subject | Re: [PATCH] isdn/hisax: Remove unnecessary parenthesis | From | David Miller <> |
| |
From: Nathan Chancellor <natechancellor@gmail.com> Date: Wed, 19 Sep 2018 21:05:23 -0700
> Clang warns when more than one set of parentheses are used for single > conditional statements: > > drivers/isdn/hisax/w6692.c:627:30: warning: equality comparison with > extraneous parentheses [-Wparentheses-equality] > if ((cs->dc.w6692.ph_state == W_L1IND_DRD)) { > ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~ > drivers/isdn/hisax/w6692.c:627:30: note: remove extraneous parentheses > around the comparison to silence this warning > if ((cs->dc.w6692.ph_state == W_L1IND_DRD)) { > ~ ^ ~ > drivers/isdn/hisax/w6692.c:627:30: note: use '=' to turn this equality > comparison into an assignment > if ((cs->dc.w6692.ph_state == W_L1IND_DRD)) { > ^~ > = > 1 warning generated. > > Remove the parentheses to silence this warning. > > Reported-by: Nick Desaulniers <ndesaulniers@google.com> > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Applied.
| |