lkml.org 
[lkml]   [2018]   [Sep]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH net-next, 1/3] hv_netvsc: Add support for LRO/RSC in the vSwitch
Date


> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Thursday, September 20, 2018 4:48 PM
> To: Haiyang Zhang <haiyangz@linuxonhyperv.com>
> Cc: Haiyang Zhang <haiyangz@microsoft.com>; davem@davemloft.net;
> netdev@vger.kernel.org; olaf@aepfle.de; linux-kernel@vger.kernel.org;
> devel@linuxdriverproject.org; vkuznets <vkuznets@redhat.com>
> Subject: Re: [PATCH net-next, 1/3] hv_netvsc: Add support for LRO/RSC in the
> vSwitch
>
> On Thu, 20 Sep 2018 17:06:59 +0000
> Haiyang Zhang <haiyangz@linuxonhyperv.com> wrote:
>
> > +static inline void rsc_add_data
> > + (struct netvsc_channel *nvchan,
> > + const struct ndis_pkt_8021q_info *vlan,
> > + const struct ndis_tcp_ip_checksum_info *csum_info,
> > + void *data, u32 len)
> > +{
>
> Could this be changed to look more like a function and skip the inline.
> The compiler will end up inlining it anyway.
>
> static void rsc_add_data(struct netvsc_channel *nvchan,

How about this?
static inline
void rsc_add_data(struct netvsc_channel *nvchan,



\
 
 \ /
  Last update: 2018-09-20 22:57    [W:0.246 / U:0.856 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site