Messages in this thread | | | From | Ricardo Ribalda Delgado <> | Date | Thu, 20 Sep 2018 22:32:23 +0200 | Subject | Re: [PATCH v2 2/4] [media] ad5820: Add support for enable pin |
| |
Hi On Thu, Sep 20, 2018 at 10:21 PM Pavel Machek <pavel@ucw.cz> wrote: > > Hi! > > > > > > ad5820: dac@0c { > > > > > compatible = "adi,ad5820"; > > > > > reg = <0x0c>; > > > > > > > > > > VANA-supply = <&pm8994_l23>; > > > > > enable-gpios = <&msmgpio 26 GPIO_ACTIVE_HIGH>; > > > > > }; > > > > > > > > Well, I'm sure you could have gpio-based regulator powered from > > > > pm8994_l23, and outputting to ad5820. > > > > > > > > Does ad5820 chip have a gpio input for enable? > > > > > > xshutdown pin: > > > http://www.analog.com/media/en/technical-documentation/data-sheets/AD5821.pdf > > > > > > (AD5820,AD5821, and AD5823 are compatibles, or at least that is waht > > > the module manufacturer says :) > > > > Aha, sorry for the noise. > > > > 2,3: Acked-by: Pavel Machek <pavel@ucw.cz> > > And I forgot to mention. If ad5821 and ad5823 are compatible, it would > be good to mention it somewhere where it is easy to find... That can > save quite a bit of work to someone. >
For the ad5821 I have the datasheet and I would not mind adding it For the ad5823 I have no datasheet, just a schematic from a camera module saying: you can replace ad5823 with ad5821.
I think I will add this as an extra patch
> Thanks, > Pavel > > > -- > (english) http://www.livejournal.com/~pavelmachek > (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-- Ricardo Ribalda
| |