Messages in this thread | | | Date | Mon, 17 Sep 2018 18:23:42 +0200 | From | Oleg Nesterov <> | Subject | Re: [RFC][PATCH 2/3] exec: Simplify unshare_files |
| |
absolutely off-topic question,
On 09/16, Eric W. Biederman wrote: > > @@ -747,11 +746,9 @@ void do_coredump(const siginfo_t *siginfo) > } > > /* get us an unshared descriptor table; almost always a no-op */ > - retval = unshare_files(&displaced); > + retval = unshare_files();
I fail to understand why do_coredump() needs unshare_files(). Could someone explain?
And "almost always a no-op" above is not true, this is never a no-op in mt case; other (killed) threads sleep in exit_mm() which is called before exit_files().
Oleg.
| |