Messages in this thread | | | Subject | Re: [RFC PATCH v2 2/3] dt-bindings: fpga: Add bindings for ZynqMP nvmem driver | From | Srinivas Kandagatla <> | Date | Sun, 16 Sep 2018 15:10:33 +0100 |
| |
Hi Rob,
Do you have any comments on the bindings side of it.
I would like to queue this for next release..
On 04/09/18 10:52, Nava kishore Manne wrote: > Add documentation to describe Xilinx ZynqMP nvmem driver > bindings. > > Signed-off-by: Nava kishore Manne <nava.manne@xilinx.com> > --- > Changes for v2: > -Moved nvmem_firmware node as a child to > firwmare node. > > .../firmware/xilinx/xlnx,zynqmp-firmware.txt | 35 ++++++++++++++++++++++ > 1 file changed, 35 insertions(+) > > diff --git a/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.txt b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.txt > index 1b431d9..4b95fcc 100644 > --- a/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.txt > +++ b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.txt > @@ -17,6 +17,19 @@ Required properties: > - "smc" : SMC #0, following the SMCCC > - "hvc" : HVC #0, following the SMCCC > > +-------------------------------------------------------------------------- > += Zynq UltraScale+ MPSoC nvmem firmware driver binding = > +-------------------------------------------------------------------------- > +The nvmem_firmware node provides access to the hardware related data > +like soc revision, IDCODE... etc, By using the firmware interface. > + > +Required properties: > +- compatible: should be "xlnx,zynqmp-nvmem-fw" > + > += Data cells = > +Are child nodes of silicon id, bindings of which as described in > +bindings/nvmem/nvmem.txt > + > ------- > Example > ------- > @@ -25,5 +38,27 @@ firmware { > zynqmp_firmware: zynqmp-firmware { > compatible = "xlnx,zynqmp-firmware"; > method = "smc"; > + nvmem_firmware { > + compatible = "xlnx,zynqmp-nvmem-fw"; > + #address-cells = <1>; > + #size-cells = <1>; > + > + /* Data cells */ > + soc_revision: soc_revision { > + reg = <0x0 0x4>; > + }; > + }; > }; > }; > + > += Data consumers = > +Are device nodes which consume nvmem data cells. > + > +For example: > + > + pcap { > + ... > + nvmem-cells = <&soc_revision>; > + nvmem-cell-names = "soc_revision"; > + }; > + > Thanks, srni
| |