lkml.org 
[lkml]   [2018]   [Sep]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v4 3/5] dt-bindings: fxas21002c: Document the fxas21002c I2C bindings
    On Tue, 11 Sep 2018 16:00:09 +0100
    Afonso Bordado <afonsobordado@az8.co> wrote:

    > Add documentation for the fxas21002c I2C bindings.
    >
    > Signed-off-by: Afonso Bordado <afonsobordado@az8.co>
    > ---
    > .../bindings/iio/gyroscope/fsl,fxas21002c.txt | 33 +++++++++++++++++++
    > 1 file changed, 33 insertions(+)
    > create mode 100644 Documentation/devicetree/bindings/iio/gyroscope/fsl,fxas21002c.txt
    >
    > diff --git a/Documentation/devicetree/bindings/iio/gyroscope/fsl,fxas21002c.txt b/Documentation/devicetree/bindings/iio/gyroscope/fsl,fxas21002c.txt
    > new file mode 100644
    > index 000000000000..9e5cdf0c0b69
    > --- /dev/null
    > +++ b/Documentation/devicetree/bindings/iio/gyroscope/fsl,fxas21002c.txt
    > @@ -0,0 +1,33 @@
    > +* Freescale FXAS21002C Digital Angular Rate Gyroscope
    > +
    > +Required properties:
    > +
    > + - compatible: must be "fsl,fxas21002c"
    > + - reg : the I2C address of the sensor
    > +
    > +Optional properties:
    > +
    > + - interrupts : The first interrupt listed must be the one
    > + connected to the INT1 pin, the second interrupt
    > + listed must be the one connected to the INT2 pin.
    > + The interrupts can be triggered on rising or falling
    > + edges alike.
    > + see interrupt-controller/interrupts.txt
    > + - vdd-supply : The main voltage regulator
    > + - iovdd-supply : The IO voltage regulator
    > + see regulator/regulator.txt
    > + - reset-gpios : GPIO used to reset the device.
    > + see gpio/gpio.txt.
    > + - mount-matrix : see iio/mount-matrix.txt

    This last one could do with a very brief introduction to what
    it is (as well as the cross reference).
    This is particularly true as it isn't clear whether it is
    necessary or optional. The below doesn't have it there for
    example.

    > +
    > +Example:
    > +gyroscope@20 {
    > + compatible = "fsl,fxas21002c";
    > + reg = <0x20>;
    > + reset-gpios = <&gpio0 2 0>;
    > + vdd-supply = <&vref>;
    > + iovdd-supply = <&vref2>;
    > + interrupt-parent = <&foo>;
    > + interrupts = <0 IRQ_TYPE_EDGE_RISING>,
    > + <1 (IRQ_TYPE_EDGE_RISING | IRQ_TYPE_EDGE_FALLING)>;
    Perhaps keep these in the same order as in the description above.

    > +};

    \
     
     \ /
      Last update: 2018-09-16 15:01    [W:4.358 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site