lkml.org 
[lkml]   [2018]   [Sep]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH net-next] net/smc: cast sizeof to int for comparison
    Date
    Comparing an int to a size, which is unsigned, causes the int to become
    unsigned, giving the wrong result. kernel_sendmsg can return a negative
    error code.

    Signed-off-by: YueHaibing <yuehaibing@huawei.com>
    ---
    net/smc/smc_clc.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/net/smc/smc_clc.c b/net/smc/smc_clc.c
    index 83aba9a..fd0f5ce 100644
    --- a/net/smc/smc_clc.c
    +++ b/net/smc/smc_clc.c
    @@ -446,7 +446,7 @@ int smc_clc_send_proposal(struct smc_sock *smc, int smc_type,
    vec[i++].iov_len = sizeof(trl);
    /* due to the few bytes needed for clc-handshake this cannot block */
    len = kernel_sendmsg(smc->clcsock, &msg, vec, i, plen);
    - if (len < sizeof(pclc)) {
    + if (len < (int)sizeof(pclc)) {
    if (len >= 0) {
    reason_code = -ENETUNREACH;
    smc->sk.sk_err = -reason_code;
    --
    1.8.3.1

    \
     
     \ /
      Last update: 2018-09-15 12:01    [W:2.694 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site