lkml.org 
[lkml]   [2018]   [Sep]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 07/20] platform: goldfish: pipe: Replace an array of 1 with a variable
On Mon, Aug 27, 2018 at 11:23:02AM -0700, rkir@google.com wrote:
> From: Roman Kiryanov <rkir@google.com>
>
> There is no reason to have an array of 1.
>
> Signed-off-by: Roman Kiryanov <rkir@google.com>
> ---
> drivers/platform/goldfish/goldfish_pipe.c | 28 +++++++++++------------
> 1 file changed, 13 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/platform/goldfish/goldfish_pipe.c b/drivers/platform/goldfish/goldfish_pipe.c
> index 24e40deb98cc..e9e3e791c0d4 100644
> --- a/drivers/platform/goldfish/goldfish_pipe.c
> +++ b/drivers/platform/goldfish/goldfish_pipe.c
> @@ -205,7 +205,7 @@ struct goldfish_pipe_dev {
> unsigned char __iomem *base;
> };
>
> -static struct goldfish_pipe_dev pipe_dev[1] = {};
> +struct goldfish_pipe_dev goldfish_pipe_dev;


Why do you need a static structure at all? Shouldn't this be tied to
the dynamic device the driver core gives you? That way you can handle
any number of these devices without any code changes needed.

thanks,

greg k-h

\
 
 \ /
  Last update: 2018-09-14 15:31    [W:0.102 / U:11.968 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site