lkml.org 
[lkml]   [2018]   [Sep]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v5 5/7] mm, hmm: Use devm semantics for hmm_devmem_{add, remove}
    On Wed, Sep 12, 2018 at 07:22:27PM -0700, Dan Williams wrote:
    > devm semantics arrange for resources to be torn down when
    > device-driver-probe fails or when device-driver-release completes.
    > Similar to devm_memremap_pages() there is no need to support an explicit
    > remove operation when the users properly adhere to devm semantics.
    >
    > Note that devm_kzalloc() automatically handles allocating node-local
    > memory.
    >
    > Reviewed-by: Christoph Hellwig <hch@lst.de>

    Given that we have no single user of these function I still think we
    should just remove them.

    \
     
     \ /
      Last update: 2018-09-14 15:18    [W:4.236 / U:0.136 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site