Messages in this thread | | | Date | Fri, 14 Sep 2018 15:18:38 +0200 | From | Christoph Hellwig <> | Subject | Re: [PATCH v5 5/7] mm, hmm: Use devm semantics for hmm_devmem_{add, remove} |
| |
On Wed, Sep 12, 2018 at 07:22:27PM -0700, Dan Williams wrote: > devm semantics arrange for resources to be torn down when > device-driver-probe fails or when device-driver-release completes. > Similar to devm_memremap_pages() there is no need to support an explicit > remove operation when the users properly adhere to devm semantics. > > Note that devm_kzalloc() automatically handles allocating node-local > memory. > > Reviewed-by: Christoph Hellwig <hch@lst.de>
Given that we have no single user of these function I still think we should just remove them.
| |