lkml.org 
[lkml]   [2018]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 41/50] dgnc: break-related ioctls won't reach ->ioctl()
    Date
    From: Al Viro <viro@zeniv.linux.org.uk>

    kill the dead code, especially since ->break_ctl() will do the
    right thing anyway.

    Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
    ---
    drivers/staging/dgnc/dgnc_tty.c | 75 -----------------------------------------
    1 file changed, 75 deletions(-)

    diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
    index 9accaa705820..040af55e9e68 100644
    --- a/drivers/staging/dgnc/dgnc_tty.c
    +++ b/drivers/staging/dgnc/dgnc_tty.c
    @@ -2081,81 +2081,6 @@ static int dgnc_tty_ioctl(struct tty_struct *tty, unsigned int cmd,

    switch (cmd) {
    /* Here are all the standard ioctl's that we MUST implement */
    -
    - case TCSBRK:
    - /*
    - * TCSBRK is SVID version: non-zero arg --> no break
    - * this behaviour is exploited by tcdrain().
    - *
    - * According to POSIX.1 spec (7.2.2.1.2) breaks should be
    - * between 0.25 and 0.5 seconds so we'll ask for something
    - * in the middle: 0.375 seconds.
    - */
    - rc = tty_check_change(tty);
    - spin_unlock_irqrestore(&ch->ch_lock, flags);
    - if (rc)
    - return rc;
    -
    - rc = ch_bd_ops->drain(tty, 0);
    - if (rc)
    - return -EINTR;
    -
    - spin_lock_irqsave(&ch->ch_lock, flags);
    -
    - if (((cmd == TCSBRK) && (!arg)) || (cmd == TCSBRKP))
    - ch_bd_ops->send_break(ch, 250);
    -
    - spin_unlock_irqrestore(&ch->ch_lock, flags);
    -
    - return 0;
    -
    - case TCSBRKP:
    - /*
    - * support for POSIX tcsendbreak()
    - * According to POSIX.1 spec (7.2.2.1.2) breaks should be
    - * between 0.25 and 0.5 seconds so we'll ask for something
    - * in the middle: 0.375 seconds.
    - */
    - rc = tty_check_change(tty);
    - spin_unlock_irqrestore(&ch->ch_lock, flags);
    - if (rc)
    - return rc;
    -
    - rc = ch_bd_ops->drain(tty, 0);
    - if (rc)
    - return -EINTR;
    -
    - spin_lock_irqsave(&ch->ch_lock, flags);
    -
    - ch_bd_ops->send_break(ch, 250);
    -
    - spin_unlock_irqrestore(&ch->ch_lock, flags);
    -
    - return 0;
    -
    - case TIOCSBRK:
    - rc = tty_check_change(tty);
    - spin_unlock_irqrestore(&ch->ch_lock, flags);
    - if (rc)
    - return rc;
    -
    - rc = ch_bd_ops->drain(tty, 0);
    - if (rc)
    - return -EINTR;
    -
    - spin_lock_irqsave(&ch->ch_lock, flags);
    -
    - ch_bd_ops->send_break(ch, 250);
    -
    - spin_unlock_irqrestore(&ch->ch_lock, flags);
    -
    - return 0;
    -
    - case TIOCCBRK:
    - /* Do Nothing */
    - spin_unlock_irqrestore(&ch->ch_lock, flags);
    - return 0;
    -
    case TIOCGSOFTCAR:

    spin_unlock_irqrestore(&ch->ch_lock, flags);
    --
    2.11.0
    \
     
     \ /
      Last update: 2018-09-13 04:42    [W:4.118 / U:0.100 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site