Messages in this thread | | | Subject | Re: [PATCH v2 02/24] drivers/video/fbdev: use ioremap_wc/wt() instead of __ioremap() | From | Bartlomiej Zolnierkiewicz <> | Date | Thu, 13 Sep 2018 19:02:31 +0200 |
| |
On 09/12/2018 05:58 PM, Christophe Leroy wrote: > _PAGE_NO_CACHE is a platform specific flag. In addition, this flag > is misleading because one would think it requests a noncached page > whereas a noncached page is _PAGE_NO_CACHE | _PAGE_GUARDED > > _PAGE_NO_CACHE alone means write combined noncached page, so lets > use ioremap_wc() instead. > > _PAGE_WRITETHRU is also platform specific flag. Use ioremap_wt() > instead. > > Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
After reading patch #1 this one LGTM.
Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> --- > drivers/video/fbdev/chipsfb.c | 3 +-- > drivers/video/fbdev/controlfb.c | 5 +---- > drivers/video/fbdev/platinumfb.c | 5 +---- > drivers/video/fbdev/valkyriefb.c | 12 ++++++------ > 4 files changed, 9 insertions(+), 16 deletions(-)
Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics
| |