Messages in this thread | | | From | Laurent Pinchart <> | Subject | Re: [PATCH 05/10] udmabuf: constify udmabuf_create args | Date | Tue, 11 Sep 2018 12:39:16 +0300 |
| |
Hi Gerd,
Thank you for the patch.
On Tuesday, 11 September 2018 09:59:16 EEST Gerd Hoffmann wrote: > Reported-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> > --- > drivers/dma-buf/udmabuf.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/dma-buf/udmabuf.c b/drivers/dma-buf/udmabuf.c > index 44c3c1bf20..0cf7e85585 100644 > --- a/drivers/dma-buf/udmabuf.c > +++ b/drivers/dma-buf/udmabuf.c > @@ -116,8 +116,8 @@ static const struct dma_buf_ops udmabuf_ops = { > #define SEALS_WANTED (F_SEAL_SHRINK) > #define SEALS_DENIED (F_SEAL_WRITE) > > -static long udmabuf_create(struct udmabuf_create_list *head, > - struct udmabuf_create_item *list) > +static long udmabuf_create(struct const udmabuf_create_list *head, > + struct const udmabuf_create_item *list)
Shouldn't it be const struct, not struct const ?
With that fixed,
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> { > DEFINE_DMA_BUF_EXPORT_INFO(exp_info); > struct file *memfd = NULL;
-- Regards,
Laurent Pinchart
| |