lkml.org 
[lkml]   [2018]   [Aug]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [alsa-devel] [PATCH] ASoC: adav80x: mark expected switch fall-through
On Thu, Aug 09, 2018 at 01:23:58PM +0200, Lars-Peter Clausen wrote:
> On 08/09/2018 11:30 AM, Mark Brown wrote:

> It is. But it might make sense to re-order the code to look like
>
> case 54000000:
> if (source != ADAV80X_PLL_SRC_XIN)
> return -EINVAL;
>
> pll_ctrl1 |= ADAV80X_PLL_CTRL1_PLLDIV;
> break;

> It is just as many lines added when adding the /* fall through */, but it
> makes it more obvious what is going on.

Yes, it's much more obvious.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2018-08-09 15:47    [W:0.022 / U:0.336 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site