lkml.org 
[lkml]   [2018]   [Aug]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 10/40] soc/tegra: pmc: Implement pad configuration via pinctrl
    On Thu, 9 Aug 2018 14:27:06 +0200
    Thierry Reding <thierry.reding@gmail.com> wrote:

    > On Wed, Aug 01, 2018 at 07:32:00PM +0300, Aapo Vienamo wrote:
    > > Register a pinctrl device and implement get and set functions for
    > > PIN_CONFIG_LOW_POWER_MODE and PIN_CONFIG_POWER_SOURCE parameters.
    > >
    > > Signed-off-by: Aapo Vienamo <avienamo@nvidia.com>
    > > Acked-by: Jon Hunter <jonathanh@nvidia.com>
    > > ---
    > > drivers/soc/tegra/pmc.c | 187 +++++++++++++++++++++++++++++++++++++++++++++++-
    > > 1 file changed, 185 insertions(+), 2 deletions(-)
    > >
    > > diff --git a/drivers/soc/tegra/pmc.c b/drivers/soc/tegra/pmc.c
    > [...]
    > > @@ -1704,6 +1863,12 @@ static const u8 tegra124_cpu_powergates[] = {
    > > .name = (_name), \
    > > })
    > >
    > > +#define TEGRA_IO_PIN_DESC(_id, _dpd, _voltage, _name) \
    > > + ((struct pinctrl_pin_desc) { \
    > > + .number = (_id), \
    > > + .name = (_name) \
    > > + })
    > > +
    >
    > Do we really need the explicit cast to struct pinctrl_pin_desc here?
    >

    No, but I prefer to have it as it makes the type of the value the macro
    expands to explicit. In a way it hints at how and where the macro should
    be used and arguably improves readability.

    -Aapo

    \
     
     \ /
      Last update: 2018-08-09 14:45    [W:4.662 / U:0.176 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site