lkml.org 
[lkml]   [2018]   [Aug]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 03/40] dt-bindings: Add Tegra SDHCI pad pdpu offset bindings
On Wed, Aug 01, 2018 at 07:31:53PM +0300, Aapo Vienamo wrote:
> Add bindings documentation for pad pull up and pull down offset values to be
> programmed before executing automatic pad drive strength calibration.
>
> Signed-off-by: Aapo Vienamo <avienamo@nvidia.com>
> ---
> .../bindings/mmc/nvidia,tegra20-sdhci.txt | 36 ++++++++++++++++++++++
> 1 file changed, 36 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/nvidia,tegra20-sdhci.txt b/Documentation/devicetree/bindings/mmc/nvidia,tegra20-sdhci.txt
> index 90c214d..2e973b5 100644
> --- a/Documentation/devicetree/bindings/mmc/nvidia,tegra20-sdhci.txt
> +++ b/Documentation/devicetree/bindings/mmc/nvidia,tegra20-sdhci.txt
> @@ -24,6 +24,7 @@ Required properties:
> Optional properties:
> - power-gpios : Specify GPIOs for power control
>
> +Optional properties for Tegra210 and Tegra186:

This looks like a stray addition.

> Example:
>
> sdhci@c8000200 {
> @@ -45,6 +46,37 @@ Optional properties for Tegra210 and Tegra186:
> for controllers supporting multiple voltage levels. The order of names
> should correspond to the pin configuration states in pinctrl-0 and
> pinctrl-1.
> +- nvidia,only-1-8-v : The presence of this property indicates that the
> + controller operates at a 1.8 V fixed I/O voltage.
> +- nvidia,pad-autocal-pull-up-offset-3v3,
> + nvidia,pad-autocal-pull-down-offset-3v3 : Specify drive strength
> + calibration offsets for 3.3 V signaling modes.
> +- nvidia,pad-autocal-pull-up-offset-1v8,
> + nvidia,pad-autocal-pull-down-offset-1v8 : Specify drive strength
> + calibration offsets for 1.8 V signaling modes.
> +- nvidia,pad-autocal-pull-up-offset-3v3-timeout,
> + nvidia,pad-autocal-pull-down-offset-3v3-timeout : Specify drive
> + strength used as a fallback in case the automatic calibration times
> + out on a 3.3 V signaling mode.
> +- nvidia,pad-autocal-pull-up-offset-1v8-timeout,
> + nvidia,pad-autocal-pull-down-offset-1v8-timeout : Specify drive
> + strength used as a fallback in case the automatic calibration times
> + out on a 1.8 V signaling mode.
> +- nvidia,pad-autocal-pull-up-offset-sdr104,
> + nvidia,pad-autocal-pull-down-offset-sdr104 : Specify drive strength
> + calibration offsets for SDR104 mode.
> +- nvidia,pad-autocal-pull-up-offset-hs400,
> + nvidia,pad-autocal-pull-down-offset-hs400 : Specify drive strength
> + calibration offsets for HS400 mode.

There's no mention here about how many values each of these properties
needs. I guess given that the property names are singular it implies a
single value.

Thierry
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2018-08-09 14:19    [W:0.176 / U:1.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site