lkml.org 
[lkml]   [2018]   [Aug]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH mmc-next v3 0/3] solve SDHCI DWC MSHC 128MB DMA boundary limitation
Hi Adrian, Ulf,

could you please review these patches? Any comments are welcome.

Thanks in advance,
Jisheng

On Mon, 30 Jul 2018 10:42:28 +0800 Jisheng Zhang wrote:

> When using DMA, if the DMA addr spans 128MB boundary, we have to split
> the DMA transfer into two so that each one doesn't exceed the boundary.
>
> patch1 adds adma_table_num to struct sdhci_host so that driver can
> control the ADMA table number.
> patch2 introduces adma_write_desc() hook to struct sdhci_ops so that
> driver can override it.
> patch3 finally solves the 128MB boundary limitation.
>
> since v2:
> - make use of "likely" to check (!len || BOUNDARY_OK(addr, len))
> - explictly include <linux/sizes.h> for SZ_128M
>
> since v1:
> - fix BOUNDARY_OK macro if addr+len is aligned to 128MB
> - use DIV_ROUND_UP to cal extra desc num
> - fix !len for dwcmshc_adma_write_desc()
>
> Jisheng Zhang (3):
> mmc: sdhci: add adma_table_num member to struct sdhci_host
> mmc: sdhci: introduce adma_write_desc() hook to struct sdhci_ops
> mmc: sdhci-of-dwcmshc: solve 128MB DMA boundary limitation
>
> drivers/mmc/host/sdhci-of-dwcmshc.c | 43 ++++++++++++++++++++++++++
> drivers/mmc/host/sdhci.c | 48 +++++++++++++++++++----------
> drivers/mmc/host/sdhci.h | 8 +++++
> 3 files changed, 83 insertions(+), 16 deletions(-)
>

\
 
 \ /
  Last update: 2018-08-09 04:31    [W:0.036 / U:1.944 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site