lkml.org 
[lkml]   [2018]   [Aug]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH net-next] ieee802154: Use kmemdup instead of duplicating it in ca8210_test_int_driver_write
From
Date
Hello Yue.

On 08/09/2018 10:44 AM, YueHaibing wrote:
> On 2018/8/9 16:13, Stefan Schmidt wrote:
>> Hello.
>>
>> On 08/09/2018 08:44 AM, YueHaibing wrote:
>>> Replace calls to kmalloc followed by a memcpy with a direct call to
>>> kmemdup.
>>>
>>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>>
>> Is Yue your forname and Haibing your surname? In that case having it
>> written as
>>
>> Yue Haibing <yuehaibing@huawei.com>
>
> Well, It should be this, but it's been a long time to use the former

Never to late to fix something I guess. :-)
Not blocking this patch base on this though.

>> in the from line as well as in the SOB would be better.
>>
>>> ---
>>> drivers/net/ieee802154/ca8210.c | 3 +--
>>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/net/ieee802154/ca8210.c b/drivers/net/ieee802154/ca8210.c
>>> index 58299fb..e21279d 100644
>>> --- a/drivers/net/ieee802154/ca8210.c
>>> +++ b/drivers/net/ieee802154/ca8210.c
>>> @@ -634,10 +634,9 @@ static int ca8210_test_int_driver_write(
>>> for (i = 0; i < len; i++)
>>> dev_dbg(&priv->spi->dev, "%#03x\n", buf[i]);
>>>
>>> - fifo_buffer = kmalloc(len, GFP_KERNEL);
>>> + fifo_buffer = kmemdup(buf, len, GFP_KERNEL);
>>> if (!fifo_buffer)
>>> return -ENOMEM;
>>> - memcpy(fifo_buffer, buf, len);
>>> kfifo_in(&test->up_fifo, &fifo_buffer, 4);
>>> wake_up_interruptible(&priv->test.readq);
>>
>> Is this some kernel tree wide change you are submitting patches for or
>> only for the ca8210 driver? Is there any specific problem you see with
>> the kmalloc and memcpy code here? To me it looks fine.
>>
>> The reason I ask is to understand if this is bug fix or a cleanup.
>
> It just a code cleanup only for ca8210.

Thanks for the info. I will wait for Harry's ack and apply it to
wpan-next afterwards.

regards
Stefan Schmidt

\
 
 \ /
  Last update: 2018-08-09 10:58    [W:0.044 / U:0.508 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site