Messages in this thread | | | From | "Luck, Tony" <> | Subject | RE: sb_edac.c lacks PCI domain support? | Date | Wed, 8 Aug 2018 20:18:03 +0000 |
| |
> I think sb_edac.c (and probably other EDAC stuff) lacks PCI domain > support
There's a patch queued to fix this.
https://marc.info/?l=linux-edac&m=153256485215534&w=2
> It looks like 88ae80aa609c ("EDAC, skx_edac: Handle systems with > segmented PCI busses") fixes a similar problem; maybe that should > be applied elsewhere in EDAC as well? > > Why doesn't EDAC use the standard pci_register_driver() interface? > That would avoid issues like this. It would also avoid the potential > conflict of another driver operating on the device at the same time.
EDAC drivers get information to translate system physical addresses to DIMM addresses from a whole bundle of different PCIe devices config space. Connections between different parts of the translation algorithm depend on finding the devices that belong to the same memory controller by matching up bus numbers (actually <segment,busnumber> tuples as we are now finding).
Can pci_register_driver() cope with this odd usage?
-Tony
| |