Messages in this thread | | | Date | Wed, 8 Aug 2018 10:31:48 +0100 | From | Mark Brown <> | Subject | Re: [PATCH 2/2] spi: sprd: Add SPI driver for Spreadtrum SC9860 |
| |
On Wed, Aug 08, 2018 at 10:45:33AM +0800, Baolin Wang wrote: > On 7 August 2018 at 22:24, Mark Brown <broonie@kernel.org> wrote: > > On Tue, Aug 07, 2018 at 06:43:38PM +0800, Baolin Wang wrote:
> >> + bits_per_word = bits_per_word > 16 ? round_up(bits_per_word, 16) : > >> + round_up(bits_per_word, 8);
> > Please
> Sorry I did not get your points here, could you elaborate on?
Sorry, missed the actual comment there - use normal if statements rather than the ternery operator, it's easier to read. [unhandled content-type:application/pgp-signature] | |