lkml.org 
[lkml]   [2018]   [Aug]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v5 04/13] drm/nouveau: Remove useless poll_disable() call in switcheroo_set_state()
    Date
    This won't do anything but potentially make us miss hotplugs. We already
    call drm_kms_helper_poll_disable() in
    nouveau_pmops_suspend()->nouveau_display_suspend()->nouveau_display_fini()

    Signed-off-by: Lyude Paul <lyude@redhat.com>
    Cc: Lukas Wunner <lukas@wunner.de>
    Cc: Karol Herbst <karolherbst@gmail.com>
    [omitting stable Cc, this likely doesn't fix anything important enough
    for that]
    ---
    drivers/gpu/drm/nouveau/nouveau_vga.c | 1 -
    1 file changed, 1 deletion(-)

    diff --git a/drivers/gpu/drm/nouveau/nouveau_vga.c b/drivers/gpu/drm/nouveau/nouveau_vga.c
    index 09b1d8151881..8f1ce4833230 100644
    --- a/drivers/gpu/drm/nouveau/nouveau_vga.c
    +++ b/drivers/gpu/drm/nouveau/nouveau_vga.c
    @@ -50,7 +50,6 @@ nouveau_switcheroo_set_state(struct pci_dev *pdev,
    } else {
    pr_err("VGA switcheroo: switched nouveau off\n");
    dev->switch_power_state = DRM_SWITCH_POWER_CHANGING;
    - drm_kms_helper_poll_disable(dev);
    nouveau_switcheroo_optimus_dsm();
    nouveau_pmops_suspend(&pdev->dev);
    dev->switch_power_state = DRM_SWITCH_POWER_OFF;
    --
    2.17.1
    \
     
     \ /
      Last update: 2018-08-07 22:41    [W:3.537 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site