lkml.org 
[lkml]   [2018]   [Aug]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 04/21] scsi: qla2xxx: Return error when TMF returns
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Anil Gurumurthy <anil.gurumurthy@cavium.com>

    commit b4146c4929ef61d5afca011474d59d0918a0cd82 upstream.

    Propagate the task management completion status properly to avoid
    unnecessary waits for commands to complete.

    Fixes: faef62d13463 ("[SCSI] qla2xxx: Fix Task Management command asynchronous handling")
    Cc: <stable@vger.kernel.org>
    Signed-off-by: Anil Gurumurthy <anil.gurumurthy@cavium.com>
    Signed-off-by: Himanshu Madhani <himanshu.madhani@cavium.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/scsi/qla2xxx/qla_init.c | 7 +++----
    1 file changed, 3 insertions(+), 4 deletions(-)

    --- a/drivers/scsi/qla2xxx/qla_init.c
    +++ b/drivers/scsi/qla2xxx/qla_init.c
    @@ -1326,11 +1326,10 @@ qla2x00_async_tm_cmd(fc_port_t *fcport,

    wait_for_completion(&tm_iocb->u.tmf.comp);

    - rval = tm_iocb->u.tmf.comp_status == CS_COMPLETE ?
    - QLA_SUCCESS : QLA_FUNCTION_FAILED;
    + rval = tm_iocb->u.tmf.data;

    - if ((rval != QLA_SUCCESS) || tm_iocb->u.tmf.data) {
    - ql_dbg(ql_dbg_taskm, vha, 0x8030,
    + if (rval != QLA_SUCCESS) {
    + ql_log(ql_log_warn, vha, 0x8030,
    "TM IOCB failed (%x).\n", rval);
    }


    \
     
     \ /
      Last update: 2018-08-07 21:06    [W:6.468 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site