| From | Greg Kroah-Hartman <> | Subject | [PATCH 3.18 51/85] scsi: megaraid: silence a static checker bug | Date | Tue, 7 Aug 2018 20:51:53 +0200 |
| |
3.18-stable review patch. If anyone has any objections, please let me know.
------------------
From: Dan Carpenter <dan.carpenter@oracle.com>
[ Upstream commit 27e833dabab74ee665e487e291c9afc6d71effba ]
If we had more than 32 megaraid cards then it would cause memory corruption. That's not likely, of course, but it's handy to enforce it and make the static checker happy.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> Signed-off-by: Sasha Levin <alexander.levin@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> --- drivers/scsi/megaraid.c | 3 +++ 1 file changed, 3 insertions(+)
--- a/drivers/scsi/megaraid.c +++ b/drivers/scsi/megaraid.c @@ -4200,6 +4200,9 @@ megaraid_probe_one(struct pci_dev *pdev, int irq, i, j; int error = -ENODEV; + if (hba_count >= MAX_CONTROLLERS) + goto out; + if (pci_enable_device(pdev)) goto out; pci_set_master(pdev);
|