lkml.org 
[lkml]   [2018]   [Aug]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] ASoC: rt5677: Remove bogus device id from rt5677_of_match
On Tue, Aug 7, 2018 at 9:22 AM Matthias Kaehlcke <mka@chromium.org> wrote:
>
> The initializer of rt5677_of_match contains a bogus device id
> (enum type) for the 'type' field (char []). Remove it.
>
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> ---
> sound/soc/codecs/rt5677.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/codecs/rt5677.c b/sound/soc/codecs/rt5677.c
> index 8a0181a2db08..7dab53b35cbf 100644
> --- a/sound/soc/codecs/rt5677.c
> +++ b/sound/soc/codecs/rt5677.c
> @@ -5007,7 +5007,7 @@ static const struct regmap_config rt5677_regmap = {
> };
>
> static const struct of_device_id rt5677_of_match[] = {
> - { .compatible = "realtek,rt5677", RT5677 },
> + { .compatible = "realtek,rt5677", },

Is that indeed not used, or should it be the following ?
... , .data = RT5677 },

Thanks,
Guenter

> { }
> };
> MODULE_DEVICE_TABLE(of, rt5677_of_match);
> --
> 2.18.0.597.ga71716f1ad-goog
>

\
 
 \ /
  Last update: 2018-08-07 18:41    [W:0.071 / U:0.960 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site